Update dependency solhint to v6 #1263
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^5.0.1
->^6.0.0
Release Notes
protofire/solhint (solhint)
v6.0.0
Compare Source
BREAKING CHANGE
Some rules were removed from the recommended ruleset and other were promoted. See below:
Rules revision - #692
🟥 DEMOTED
payable-fallback
: Outdated due to the introduction of receive(); rarely needed in modern Solidity.✅ PROMOTED
interface-starts-with-i
: Promotes clarity by clearly distinguishing interfaces from contracts.gas-calldata-parameters
: Encourages optimal memory usage for external functions.gas-increment-by-one
: Suggests using ++i style for gas-efficient increments.gas-indexed-events
: Improves event indexing for off-chain systems and reduces gas usage.gas-small-strings
: Recommends cheaper encoding using bytes32 for short strings.gas-strict-inequalities
: Helps avoid subtle off-by-one bugs in range conditions.gas-struct-packing
: Maximizes storage efficiency by suggesting tight struct packing.duplicated-imports
: Prevents redundant imports that bloat the AST and confuse code structure.import-path-check
: Ensures all imported files exist and resolve correctly, avoiding runtime errors.function-max-lines
: Encourages smaller, more readable and maintainable functions.constructor-syntax
: Enforces modern constructor syntax for consistency and clarity.use-natspec
: Promotes proper documentation with NatSpec for better audits and readability.Fixed
gas-struct-packing
false positives - #690gas-increment-by-one
backward expression - #691Added
use-natspec
: Promote the use of natspec and make several checks to enforce it - #689Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.